Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check no std in CI #8716

Closed
Tracked by #8705
onbjerg opened this issue Jun 10, 2024 · 2 comments · Fixed by #8871
Closed
Tracked by #8705

Check no std in CI #8716

onbjerg opened this issue Jun 10, 2024 · 2 comments · Fixed by #8871
Assignees
Labels
A-ci Related to github workflows or other build and lint tools C-enhancement New feature or request

Comments

@onbjerg
Copy link
Collaborator

onbjerg commented Jun 10, 2024

Describe the feature

Some crates will have no std support, see #8705

Currently we don't check that these actually compile with --no-default-features (i.e. no std) in CI, but we should.

For resolving this issue, add a cargo check pass for all crates in the workspace with --no-default-features

Additional context

No response

@onbjerg onbjerg added C-enhancement New feature or request A-ci Related to github workflows or other build and lint tools labels Jun 10, 2024
@JackG-eth
Copy link
Contributor

i will take this as part of the tracker

@DaniPopes
Copy link
Member

DaniPopes commented Jun 14, 2024

Note: should be careful in not running only tests with --no-default-features, since the crates will be built with cfg(test) and other features enabled only through dev-dependencies. These enable std regardless of user-specified features and do not actually exercise no_std code paths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Related to github workflows or other build and lint tools C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants