Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: no_std CI integration #8871

Merged
merged 5 commits into from
Jun 17, 2024
Merged

feat: no_std CI integration #8871

merged 5 commits into from
Jun 17, 2024

Conversation

JackG-eth
Copy link
Contributor

Motivation

Closes #8716

Description

Currently we don't check that these actually compile with --no-default-features (i.e. no std) in CI, but we should.

@JackG-eth
Copy link
Contributor Author

Hi, Few notes on this:

  1. Should this be in the integration.yml or entirely seperated.
  2. Should this include other crates like alloy/revm or be member specific
  3. Should this include riscv32imac-unknown-none-elf in the build script?

@onbjerg onbjerg added the A-ci Related to github workflows or other build and lint tools label Jun 17, 2024
DaniPopes
DaniPopes requested changes Jun 17, 2024
View reviewed changes
@DaniPopes DaniPopes enabled auto-merge June 17, 2024 21:47
@DaniPopes DaniPopes added this pull request to the merge queue Jun 17, 2024
Merged via the queue into paradigmxyz:main with commit 5f998f7 Jun 17, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-ci Related to github workflows or other build and lint tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check no std in CI
3 participants
@JackG-eth @DaniPopes @onbjerg