fix: deadlock on StaticFileProvider::get_writer #10069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
A-consensus
|
pushed a fix. Issue is that holding receipt writer across the loop has 3/100 chance that it will deadlock if another segment writer shares the same shard will create a separate PR to stop using dashmap for writers, since it's actually an unsuitable fit |
fgimenez
force-pushed
the
fgimenez/fix-flaky-persistence-test
branch
from
f4e7e55 to
6b8ec91
Compare
fgimenez
requested review from
rakita,
joshieDo,
shekhirin,
rkrasiuk and
Rjected
as code owners
joshieDo
approved these changes
Aug 5, 2024
1 task
martinezjorge
pushed a commit
to martinezjorge/reth
that referenced
this pull request
Aug 7, 2024
Co-authored-by: joshieDo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #10046, closes #10072