Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use actual latest state for BlockchainProvider2 #10137

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Aug 6, 2024

Fixes at least one more hive engine test, this time we needed to actually construct the state provider for the latest block, if the latest block is in memory.

Introduces a helper method to get a state provider from a BlockState

@Rjected Rjected added C-bug An unexpected or incorrect behavior A-consensus Related to the consensus engine A-db Related to the database A-engine Related to the engine implementation labels Aug 6, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rjected Rjected added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit 680ca6b Aug 6, 2024
33 checks passed
@Rjected Rjected deleted the dan/more-hive-fixes branch August 6, 2024 15:19
martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Related to the consensus engine A-db Related to the database A-engine Related to the engine implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants