Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(net): Expose max seen transactions history size as cli arg #10327

Merged
merged 12 commits into from
Aug 17, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Aug 15, 2024

Ref #10326

Exposes number of seen transactions to remember per peer as a cli arg.

@emhane emhane added A-networking Related to networking in general A-cli Related to the reth CLI labels Aug 15, 2024
@emhane emhane requested a review from gakonst as a code owner August 15, 2024 20:00
@emhane emhane force-pushed the emhane/tx-fetcher-cli-args branch from 1ab8155 to 78faa0e Compare August 15, 2024 21:53
@emhane emhane force-pushed the emhane/tx-fetcher-cli-args branch from a9476f6 to a124e58 Compare August 15, 2024 23:21
@emhane emhane force-pushed the emhane/tx-fetcher-cli-args branch from a124e58 to 9f50674 Compare August 15, 2024 23:29
@emhane emhane added the C-debt A clean up/refactor of existing code label Aug 15, 2024
Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit otherwise lgtm

Co-authored-by: Oliver <[email protected]>
Base automatically changed from emhane/fix-tx-mgr-constants to main August 17, 2024 22:03
@emhane emhane enabled auto-merge August 17, 2024 22:13
@emhane emhane added this pull request to the merge queue Aug 17, 2024
Merged via the queue into main with commit 8c02aca Aug 17, 2024
34 checks passed
@emhane emhane deleted the emhane/tx-fetcher-cli-args branch August 17, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-networking Related to networking in general C-debt A clean up/refactor of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants