Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant EthChainSpec::Hardfork #10470

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Remove redundant EthChainSpec::Hardfork #10470

merged 1 commit into from
Aug 23, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Aug 22, 2024

Remove semantics which cause optimsim bug if used. ChainSpec is not an l1-exclusive type.

@emhane emhane added C-bug An unexpected or incorrect behavior A-op-reth Related to Optimism and op-reth labels Aug 22, 2024
@emhane emhane changed the title Remove redundant ChainSpec::Hardfork Remove redundant EthChainSpec::Hardfork Aug 22, 2024
@emhane emhane requested a review from klkvr August 22, 2024 21:23
@emhane emhane added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit 07bf04d Aug 23, 2024
35 checks passed
@emhane emhane deleted the emhane/fix-chainspec branch August 23, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @klkvr