Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure receipts are written to storage during test setups #10660

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Sep 2, 2024

Tests using provider_with_chain_spec_and_random_blocks were not properly committing static file data to disk.

This ensures it by using the relatively new UnifiedStorageWriter.

@joshieDo joshieDo added A-db Related to the database C-test A change that impacts how or what we test labels Sep 2, 2024
@joshieDo joshieDo added the C-bug An unexpected or incorrect behavior label Sep 2, 2024
@joshieDo joshieDo requested a review from jenpaff September 2, 2024 15:30
@joshieDo joshieDo changed the title fix: ensure receipts are written to storage on tests fix: ensure receipts are written to storage during test setups Sep 2, 2024
@joshieDo joshieDo force-pushed the push-umxzsnnlumpt branch 2 times, most recently from 6803935 to 5957f36 Compare September 2, 2024 15:35
Copy link
Collaborator

@jenpaff jenpaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@joshieDo joshieDo added this pull request to the merge queue Sep 2, 2024
Merged via the queue into main with commit aa42dbc Sep 2, 2024
34 checks passed
@joshieDo joshieDo deleted the push-umxzsnnlumpt branch September 2, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Related to the database C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants