clippy: add collection_is_never_read clippy lint

[tcoratger]

No description provided.

[tcoratger]

Here I'm not 100% sure but the ordered_hardforks collection was never read before and I have the impression that we are setting up on the few previous lines an ordering mechanism to use the ordered_hardforks here otherwise it has no interest right?

[onbjerg]

smol nit, otherwise lgtm

[onbjerg]

im not too sure what this is even used for, cc @joshieDo

[tcoratger]

I don't see any difference between using it or not but maybe there are exceptions that I don't have in mind.

If this is not used, we can simply delete the whole block of code before:

// Uses ethereum or optimism main chains to find proper order
        #[cfg(not(feature = "optimism"))]
        let mainnet_hardforks: ChainHardforks = EthereumHardfork::mainnet().into();
        #[cfg(not(feature = "optimism"))]
        let mainnet_order = mainnet_hardforks.forks_iter();
        #[cfg(feature = "optimism")]
        let mainnet_hardforks = OptimismHardfork::op_mainnet();
        #[cfg(feature = "optimism")]
        let mainnet_order = mainnet_hardforks.forks_iter();

        let mut ordered_hardforks = Vec::with_capacity(hardforks.len());
        for (hardfork, _) in mainnet_order {
            if let Some(pos) = hardforks.iter().position(|(e, _)| **e == *hardfork) {
                ordered_hardforks.push(hardforks[pos].clone());
            }
        }

[joshieDo]

actually this is a bug, and it should be hardforks: ChainHardforks::new(ordered_hardforks) as suggested, mb

lint already doing work

[tcoratger]

We love lints :)