Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reject 7702 transactions with empty auth list #10709

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix: reject 7702 transactions with empty auth list #10709

merged 1 commit into from
Sep 5, 2024
+33 −5

Conversation

onbjerg
Copy link
Collaborator

@onbjerg onbjerg commented Sep 4, 2024 •
edited
Loading

If an EIP-7702 transaction has no authorization list items it won't be included in a block, so we might as well reject it in the pool too.

@onbjerg onbjerg added C-bug An unexpected or incorrect behavior A-tx-pool Related to the transaction mempool labels Sep 4, 2024
@onbjerg onbjerg force-pushed the onbjerg/txpool-7702-empty-list branch from cca476f to aa93f22 Compare September 4, 2024 23:48
@onbjerg onbjerg requested a review from emhane as a code owner September 4, 2024 23:48
@onbjerg onbjerg added the E-prague Related to the prague network upgrade label Sep 4, 2024
mattsse
mattsse approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a hard consensus rule?

what happens if we receive one in a newPayload, do we need checks there as well?

@rakita
Copy link
Collaborator

rakita commented Sep 5, 2024

is this a hard consensus rule?

what happens if we receive one in a newPayload, do we need checks there as well?

It is checked inside Revm

@mattsse mattsse added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 5df03fb Sep 5, 2024
34 checks passed
@mattsse mattsse deleted the onbjerg/txpool-7702-empty-list branch September 5, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita rakita approved these changes

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool C-bug An unexpected or incorrect behavior E-prague Related to the prague network upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onbjerg @rakita @mattsse @rkrasiuk