fix (reth-consensus): use derive_more::Error replace std::error::Error

[nkysg]

ref #10828, fix #10831.

after #10831, use cargo expand
the code is

#[automatically_derived]
impl derive_more::Error for ConsensusError {
    fn source(&self) -> Option<&(dyn derive_more::Error + 'static)> {
        use derive_more::__private::AsDynError;
        match self {
            ConsensusError::BodyOmmersHashDiff(source) => Some(source.as_dyn_error()),
            ConsensusError::BodyStateRootDiff(source) => Some(source.as_dyn_error()),
            ConsensusError::BodyTransactionRootDiff(source) => Some(source.as_dyn_error()),
            ConsensusError::BodyReceiptRootDiff(source) => Some(source.as_dyn_error()),
            ConsensusError::BodyBloomLogDiff(source) => Some(source.as_dyn_error()),
            ConsensusError::BodyWithdrawalsRootDiff(source) => Some(source.as_dyn_error()),
            ConsensusError::BodyRequestsRootDiff(source) => Some(source.as_dyn_error()),
            ConsensusError::ParentHashMismatch(source) => Some(source.as_dyn_error()),
            ConsensusError::BlobGasUsedDiff(source) => Some(source.as_dyn_error()),
            ConsensusError::InvalidTransaction(source) => Some(source.as_dyn_error()),
            ConsensusError::BaseFeeDiff(source) => Some(source.as_dyn_error()),
            _ => None,
        }
    }
}

but the original code is

reth/crates/consensus/consensus/src/lib.rs

Lines 399 to 406 in 57fb2d2

	impl std::error::Error for ConsensusError {
	fn source(&self) -> Option<&(dyn std::error::Error + 'static)> {
	match self {
	Self::InvalidTransaction(err) => std::error::Error::source(err),
	_ => Option::None,
	}
	}
	}

[nkysg]

the rule is complexd, For me personally it feels harder to understand.

https://docs.rs/derive_more/latest/derive_more/derive.Error.html

When and how does it derive source()?
It’s a struct/variant with named fields and one is the fields is called source. Then it would return that field as the source.
It’s a tuple struct/variant and there’s exactly one field that is not used as the backtrace. So either a tuple struct with one field, or one with two where one is the backtrace. Then it returns this field as the source.
One of the fields is annotated with #[error(source)]. Then it would return that field as the source.

Ignoring fields for derives
It’s possible to ignore a field or a whole enum variant completely for this derive using the #[error(ignore)] attribute. This will ignore it both for detecting backtrace and source. It’s also possible to mark a field only ignored for one of these methods by using #[error(not(backtrace))] or #[error(not(source))].

I have tried it only support #[error(ignore)].

[mattsse]

yeah, I think we can actually keep it how it is now but use core::error::Error

[mattsse]

closing and will also close the issue per comment above