Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: without-evm cli option in reth #12134

Merged
merged 12 commits into from
Oct 29, 2024
Merged

Conversation

debjit-bw
Copy link
Contributor

Fixes #12090

Added CLI command to init-state without previously having to import blocks/receipts.

In order to try it out, you can use the following:

The optimism-specific implementation for op-geth hasn't been removed/modified.

@debjit-bw debjit-bw marked this pull request as draft October 28, 2024 11:59
@debjit-bw debjit-bw marked this pull request as ready for review October 28, 2024 12:40
@debjit-bw debjit-bw changed the title refactor: without-evm cli option in reth feat: without-evm cli option in reth Oct 28, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, this does now add the an additional command that isn't very useful for the regular ethereum CLI.

my idea for this was more like converting the existing pre-bedrock functions so that they are reusable and then move them as additional functions into the commands crate and optionally also include them into the init state command.

but this left the pre-bedrock functions untouched so far

@debjit-bw
Copy link
Contributor Author

debjit-bw commented Oct 28, 2024

@mattsse the normal cli would continue functioning as expected, as it just adds flags to the existing command. the additional fields become available only when the reth init-state --without-evm flag is used. I believe this is beneficial for other chains as well because this makes the process much simpler/faster without needing the block rlps.

I am updating the optimism create cli code to use this

Copy link
Collaborator

@joshieDo joshieDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits, but lgtm

mind adding the example as an actual test of setup_without_evm ?

@joshieDo joshieDo added A-db Related to the database A-cli Related to the reth CLI labels Oct 29, 2024
@debjit-bw
Copy link
Contributor Author

@mattsse can you have a look?

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshieDo joshieDo enabled auto-merge October 29, 2024 11:05
@joshieDo joshieDo added this pull request to the merge queue Oct 29, 2024
Merged via the queue into paradigmxyz:main with commit dd18af1 Oct 29, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-db Related to the database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make setup_op_mainnet_without_ovm general purpose
3 participants