-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: without-evm cli option in reth #12134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, this does now add the an additional command that isn't very useful for the regular ethereum CLI.
my idea for this was more like converting the existing pre-bedrock functions so that they are reusable and then move them as additional functions into the commands crate and optionally also include them into the init state command.
but this left the pre-bedrock functions untouched so far
@mattsse the normal cli would continue functioning as expected, as it just adds flags to the existing command. the additional fields become available only when the I am updating the optimism create cli code to use this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits, but lgtm
mind adding the example as an actual test of setup_without_evm
?
@mattsse can you have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes #12090
Added CLI command to
init-state
without previously having to import blocks/receipts.In order to try it out, you can use the following:
The optimism-specific implementation for op-geth hasn't been removed/modified.