Track time diff between new_payload and FCU
#12245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mattsse, let me know your thoughts on this approach and whether it should be applied to the other payloads or if any adjustments are needed. |
mattsse
requested changes
Nov 1, 2024
Comment on lines
30
to
33
| use std::{ | ||
| sync::{Arc, Mutex}, | ||
| time::Instant, | ||
| }; |
There was a problem hiding this comment.
this should use parking_lot::Mutex
| @@ -44,6 +47,7 @@ const MAX_BLOB_LIMIT: usize = 128; | |||
| /// functions in the Execution layer that are crucial for the consensus process. | |||
| pub struct EngineApi<Provider, EngineT: EngineTypes, Pool, Validator, ChainSpec> { | |||
| inner: Arc<EngineApiInner<Provider, EngineT, Pool, Validator, ChainSpec>>, | |||
| start_time: Mutex<Option<Instant>>, | |||
There was a problem hiding this comment.
this should go into the inner type, because the EngineApi type is cloned per request
Comment on lines
253
to
260
| let elapsed_time = self | ||
| .start_time | ||
| .lock() | ||
| .unwrap() | ||
| .expect("start_time should be set before fork_choice_updated_v1 is called") | ||
| .elapsed(); | ||
|
|
||
| self.inner.metrics.payload_to_fcu_latency.new_payload_v1_time_diff.record(elapsed_time); |
There was a problem hiding this comment.
we can make this a standalone function of the inner type
| .start_time | ||
| .lock() | ||
| .unwrap() | ||
| .expect("start_time should be set before fork_choice_updated_v1 is called") |
There was a problem hiding this comment.
and this can't use unwrap here, and should only update if there is an instant
| let elapsed_time = self | ||
| .start_time | ||
| .lock() | ||
| .unwrap() |
There was a problem hiding this comment.
Suggested change
| .unwrap() | |
| .take() |
|
@mattsse comments addressed, let me know how it looks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip #12212