-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): Add cumulative transaction counters to improve observability #12273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also remove open_total
, and replace any usage of it on the grafana dashboards with opened_total - closed_total
hi @onbjerg please help me review it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, pending dashboard update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending dashboard update as well. any progress on this ? @hoank101
hi @onbjerg how to update dashboard? can you show me how |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we need a new entry here
reth/etc/grafana/dashboards/overview.json
Line 1727 in f7dc27f
"expr": "sum(reth_database_transaction_open_total{instance=~\"$instance\"}) by (mode)", |
also not familiar, so ptal @onbjerg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool change!
i just updated the metrics, @onbjerg please help me review, thanks |
CodSpeed Performance ReportMerging #12273 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks! will add a followup issue for making the dashboard track open - closed
Closes #12211