Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Add cumulative transaction counters to improve observability #12273

Merged
merged 8 commits into from
Dec 30, 2024

Conversation

hoank101
Copy link
Contributor

@hoank101 hoank101 commented Nov 2, 2024

Closes #12211

@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Nov 2, 2024
Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also remove open_total, and replace any usage of it on the grafana dashboards with opened_total - closed_total

@hoank101
Copy link
Contributor Author

hi @onbjerg please help me review it

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending dashboard update

Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending dashboard update as well. any progress on this ? @hoank101

@hoank101
Copy link
Contributor Author

hi @onbjerg how to update dashboard? can you show me how

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we need a new entry here

"expr": "sum(reth_database_transaction_open_total{instance=~\"$instance\"}) by (mode)",

also not familiar, so ptal @onbjerg

Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool change!

@onbjerg
Copy link
Collaborator

onbjerg commented Dec 20, 2024

@hoank101 hoank101 requested a review from shekhirin as a code owner December 21, 2024 07:42
@hoank101
Copy link
Contributor Author

i just updated the metrics, @onbjerg please help me review, thanks

Copy link

codspeed-hq bot commented Dec 21, 2024

CodSpeed Performance Report

Merging #12273 will not alter performance

Comparing hoank101:feat/12211 (4d5cfe5) with main (0b135a2)

Summary

✅ 77 untouched benchmarks

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! will add a followup issue for making the dashboard track open - closed

@Rjected Rjected enabled auto-merge December 30, 2024 21:11
@Rjected Rjected added this pull request to the merge queue Dec 30, 2024
Merged via the queue into paradigmxyz:main with commit 4110493 Dec 30, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open read-only transactions metric does not work properly for read-only transactions
5 participants