Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queued_outgoing_messages panel for grafana #12306

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

syjn99
Copy link
Contributor

@syjn99 syjn99 commented Nov 4, 2024

This PR Addresses #12254. Added queued_outgoing_messages per second next to Incoming Gossip and Requests panel. The expression looks like:

"rate(reth_network_queued_outgoing_messages{instance=\"$instance\"}[$__rate_interval])"

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does a lot more than adding a new panel, so not sure how to best review this

can we limit this pr to the additional panel?

@Rjected

@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Nov 5, 2024
@syjn99 syjn99 force-pushed the feature/queued-outgoing-msg-panel branch from 4316cc8 to da8a48a Compare November 5, 2024 12:51
@syjn99
Copy link
Contributor Author

syjn99 commented Nov 5, 2024

@mattsse Seems like plugin version is bumped, and its diff is included. I pushed new commit so that reviewing this code would be much easier.

@syjn99 syjn99 requested a review from mattsse November 5, 2024 12:52
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, do you mind adding a screenshot of the panel?

@syjn99
Copy link
Contributor Author

syjn99 commented Nov 6, 2024

image

Here's a partial screenshot of the dashboard. New panel is next to Incoming Gossip and Requests panel. Ran clients for few hours, on ephemery network with fuzzing with tx fuzzer.
As there are no queued messages, the panel looks flat. Does this look good to you?

@syjn99 syjn99 requested a review from Rjected November 6, 2024 15:05
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice lgtm

@Rjected Rjected added this pull request to the merge queue Nov 6, 2024
Merged via the queue into paradigmxyz:main with commit c2e8e2f Nov 6, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants