-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add queued_outgoing_messages
panel for grafana
#12306
Add queued_outgoing_messages
panel for grafana
#12306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does a lot more than adding a new panel, so not sure how to best review this
can we limit this pr to the additional panel?
4316cc8
to
da8a48a
Compare
@mattsse Seems like plugin version is bumped, and its diff is included. I pushed new commit so that reviewing this code would be much easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me, do you mind adding a screenshot of the panel?
![]() Here's a partial screenshot of the dashboard. New panel is next to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice lgtm
This PR Addresses #12254. Added
queued_outgoing_messages
per second next toIncoming Gossip and Requests
panel. The expression looks like: