fix: eth_getProof response
#12370
Merged
fix: eth_getProof response
#12370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Nov 7, 2024
| @@ -7,7 +7,7 @@ use reth_trie_common::{AccountProof, StorageProof}; | |||
| /// Creates a new rpc storage proof from a primitive storage proof type. | |||
| pub fn from_primitive_storage_proof(proof: StorageProof) -> EIP1186StorageProof { | |||
| EIP1186StorageProof { | |||
| key: JsonStorageKey::Hash(proof.key), | |||
| key: JsonStorageKey::Number(proof.key.into()), | |||
There was a problem hiding this comment.
hmm, I think this is more nuanced than that, because the reason why this even is an enum is so we can mirror the input:
so i guess we'd need to take this into account here:
mattsse
approved these changes
Nov 7, 2024
klkvr
commented
Nov 7, 2024
| .storage_proofs | ||
| .into_iter() | ||
| .zip(slots) | ||
| .map(|(proof, slot)| from_primitive_storage_proof(proof, slot)) |
There was a problem hiding this comment.
@rkrasiuk is it OK to assume same order of input slots and outputted proofs here?
There was a problem hiding this comment.
it is the case rn, but i'd rather avoid such assumption since it's not documented anywhere, not covered in tests and there is no such expectation atm to proof generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keys should always be serialized as uints