Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: restrict payload builder error type #12423

Merged
merged 1 commit into from
Nov 9, 2024
Merged

chore: restrict payload builder error type #12423

merged 1 commit into from
Nov 9, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 9, 2024

this is fine because PayloadBuilderError has

reth/crates/payload/primitives/src/error.rs

Lines 39 to 41 in d94bca3

/// Any other payload building errors.
#[error(transparent)]
Other(Box<dyn core::error::Error + Send + Sync>),

and this helps with #12422

@mattsse mattsse requested a review from Rjected as a code owner November 9, 2024 12:36
@mattsse mattsse added the A-block-building Related to block building label Nov 9, 2024
@mattsse mattsse merged commit ae257f5 into main Nov 9, 2024
41 checks passed
@mattsse mattsse deleted the matt/restrict-payload-builder-error branch November 9, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-block-building Related to block building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattsse