Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: don't reference StaticFileProvider in static_file::Segment #12558

Merged
merged 2 commits into from
Nov 14, 2024
Merged

refactor: don't reference StaticFileProvider in static_file::Segment #12558

merged 2 commits into from
Nov 14, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Nov 14, 2024 •
edited
Loading

static_file::Segment needs to be object-safe so once we introduce primitives generic to StaticFileProvider we'd need to introduce same generic to Segment as well.

However, it is not necessary because we already have Provider generic there which we can get static_file_provider from by enforcing StaticFileProviderFactory on it

mattsse
mattsse approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added A-db Related to the database A-sdk Related to reth's use as a library labels Nov 14, 2024
@mattsse mattsse added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit d028c1c Nov 14, 2024
40 checks passed
@mattsse mattsse deleted the klkvr/static-files-refactor branch November 14, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-db Related to the database A-sdk Related to reth's use as a library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse