-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use body.recover_signers_unchecked
instead on try_with_senders_unchecked
#12668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
I'm checking if this fixes my problem, again thanks a lot for being so fast to reply. will update here shortly |
with this PR I still have the same problem, with my (#12666) PR i don't have it |
SealedBlock which is used in this request actually needed to be changed as well (not just Block). Can you try again? Tbh, I'm still unsure on what causes the issue. It should not matter if it's unchecked or not, since TxDeposit are "caught" on : reth/crates/primitives/src/transaction/mod.rs Lines 892 to 902 in 02a90e1
|
merging since this still makes sense on its own |
tried but still same error. I'm going to investigate a bit more why I have this error, thanks |
alternative to #12666
Block::try_with_senders_unchecked
was not using an unchecked recovery method