Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add header and body generics to SealedBlockWithSenders #12717

Merged
merged 1 commit into from
Nov 20, 2024
Merged

chore: add header and body generics to SealedBlockWithSenders #12717

merged 1 commit into from
Nov 20, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Nov 20, 2024

extracted from #12694

cc @mattsse

mattsse
mattsse approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool,
I was initially hoping we could convert this to B: Block right away, but looks like doing it like this first is more efficient for now.

@mattsse mattsse added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 749f98e Nov 20, 2024
41 checks passed
@mattsse mattsse deleted the klkvr/block-with-senders branch November 20, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse