feat: relax more tx manager bounds #12744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
A-networking
mattsse
commented
Nov 21, 2024
| impl<Pool> TransactionsManager<Pool> | ||
| where | ||
| Pool: TransactionPool + 'static, | ||
| <<Pool as TransactionPool>::Transaction as PoolTransaction>::Consensus: Into<TransactionSigned>, |
There was a problem hiding this comment.
these are currently redundant, but I'd like to keep them as a reminder that we need to enforce this conversion
klkvr
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relaxes more trait bounds in txmanager
since
TxSignedRecovered != TxSignedI had to add an additional Into bound.this will suck for a bit, but next step would be to gradually remove this, this will require some additional changes first.
no functional changes