Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Receipt AT to ReceiptProvider #12890

Merged
merged 3 commits into from
Nov 27, 2024
Merged

feat: add Receipt AT to ReceiptProvider #12890

merged 3 commits into from
Nov 27, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Nov 26, 2024 •
edited
Loading

Based on #12887

Adds Receipt AT to ReceiptProvider, for now Receipts are still bounded to reth_primitives::Receipt

@klkvr klkvr force-pushed the klkvr/provider-receipt-generic branch 3 times, most recently from 47f001d to 14f4fc4 Compare November 26, 2024 23:47
@klkvr klkvr mentioned this pull request Nov 27, 2024
Merged
mattsse
mattsse approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool

Base automatically changed from klkvr/unify-receipts-remove to main November 27, 2024 11:59
@klkvr klkvr added this pull request to the merge queue Nov 27, 2024
@klkvr klkvr removed this pull request from the merge queue due to a manual request Nov 27, 2024
@klkvr klkvr force-pushed the klkvr/provider-receipt-generic branch from 766e72f to 172c02a Compare November 27, 2024 13:42
@klkvr klkvr enabled auto-merge November 27, 2024 13:43
@klkvr klkvr added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 533b555 Nov 27, 2024
41 checks passed
@klkvr klkvr deleted the klkvr/provider-receipt-generic branch November 27, 2024 14:18
@klkvr klkvr mentioned this pull request Nov 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse