feat: on-disk reorg E2E test #12977
Merged
feat: on-disk reorg E2E test #12977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
fgimenez and
emhane
as code owners
klkvr
force-pushed
the
klkvr/engine-tests
branch
from
b725f75 to
96e1f3e
Compare
klkvr
force-pushed
the
klkvr/engine-tests
branch
from
96e1f3e to
9b58014
Compare
mattsse
approved these changes
Nov 29, 2024
crates/net/network/src/state.rs
Outdated
There was a problem hiding this comment.
these changes are now on main, so needs rebase
klkvr
force-pushed
the
klkvr/engine-tests
branch
from
9b58014 to
502a6d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test simulating that node is able to handle a long on-disk reorg and operate normally after it.
I've refactored some code into helper methods to make it easier to reuse