fix(engine): get_proof_targets only add fetched accounts if they have new storage #13015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
added
C-test
fgimenez
force-pushed
the
fgimenez/get-proof-targets-unit-tests
branch
from
57d4dfe to
3c3d140
Compare
fgimenez
changed the title
mattsse
approved these changes
Nov 30, 2024
fgimenez
changed the title
shekhirin
approved these changes
Dec 2, 2024
rkrasiuk
requested changes
Dec 2, 2024
… correct behavior and adapt code to make it pass
fgimenez
force-pushed
the
fgimenez/get-proof-targets-unit-tests
branch
from
5b88128 to
5d987df
Compare
rkrasiuk
requested changes
Dec 2, 2024
rkrasiuk
reviewed
Dec 2, 2024
rkrasiuk
reviewed
Dec 2, 2024
Co-authored-by: Roman Krasiuk <[email protected]>
Co-authored-by: Roman Krasiuk <[email protected]>
rkrasiuk
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up of #12983
The tests brought up an issue in
get_proof_targets, accounts were always added to the output if they had any storage, no matter if they were already fetched. Now, if they are present in fetched, they are only added if they have new storage.