Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Op DA config #13095

Merged
merged 1 commit into from
Dec 3, 2024
Merged

feat: add Op DA config #13095

merged 1 commit into from
Dec 3, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 3, 2024

we need to make this configurable for the OpBuilder

needs will be exposed via HTTP #13092 hence this is an atomic

ref https://github.com/ethereum-optimism/op-geth/blob/0a46245ccc5c801e7b18c258aceb5327d8ad69ad/miner/miner.go#L169-L183
https://github.com/ethereum-optimism/op-geth/blob/0a46245ccc5c801e7b18c258aceb5327d8ad69ad/miner/miner.go#L67-L69

MaxDATxSize *big.Int toml:",omitempty" // if non-nil, don't include any txs with data availability size larger than this in any built block
MaxDABlockSize *big.Int toml:",omitempty" // if non-nil, then don't build a block requiring more than this amount of total data availability

needs integration in builder once we know how to compute the DA values per tx

@mattsse mattsse added the A-op-reth Related to Optimism and op-reth label Dec 3, 2024
@mattsse mattsse enabled auto-merge December 3, 2024 12:23
rkrasiuk
rkrasiuk approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was confused at first why atomics, but makes sense per PR description

@mattsse mattsse added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit bfcd983 Dec 3, 2024
42 checks passed
@mattsse mattsse deleted the matt/add-da-config branch December 3, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @rkrasiuk