Allow replacement txs with exactly price bump #13161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Dec 5, 2024
|
btw @yaziciahmet I think we're open to support this natively via a feature: |
|
just needs rustfmt, |
hahahah I wasn't expecting my toy project to be peeped. that would actually be great. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if replacement transaction is bumped exactly by the
price_bump%, transaction is rejected due to being underpriced. This behavior doesn't match with the Geth implementation, and also doesn't work with speed-up feature of well-known wallet applications such as Metamask since they increase the fee exactly 10% (default price bump rate).Here is the exact line in Geth: https://github.com/ethereum/go-ethereum/blob/67a3b087951a3f3a8e341ae32b6ec18f3553e5cc/core/txpool/legacypool/list.go#L323
closes #13160