Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EthApi): Add broadcast stream for incoming raw transactions #13165

Merged
merged 12 commits into from
Dec 11, 2024

Conversation

TheDhejavu
Copy link
Contributor

Should resolve: #13158

@TheDhejavu TheDhejavu requested a review from fgimenez as a code owner December 5, 2024 17:31
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

left some suggestions

@TheDhejavu TheDhejavu requested a review from mattsse December 6, 2024 13:04
@mattsse
Copy link
Collaborator

mattsse commented Dec 6, 2024

@TheDhejavu I consider this completed, I need to figure out how to proceed here first.

ty

@TheDhejavu TheDhejavu force-pushed the eth-incoming-raw-tx-broadcast branch from 1a8d1a3 to ac68386 Compare December 6, 2024 21:02
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, last nit

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty

pending unused import

@mattsse mattsse enabled auto-merge December 11, 2024 13:48
@mattsse mattsse added this pull request to the merge queue Dec 11, 2024
Merged via the queue into paradigmxyz:main with commit 17d38c9 Dec 11, 2024
42 checks passed
@TheDhejavu TheDhejavu deleted the eth-incoming-raw-tx-broadcast branch December 11, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add broadcast stream for incoming raw transactions
2 participants