Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make zip_blocks generic over header #13199

Merged
merged 1 commit into from
Dec 7, 2024
Merged

chore: make zip_blocks generic over header #13199

merged 1 commit into from
Dec 7, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Dec 7, 2024

This can be done with a generic BlockHeader and body (inferred by the input)

@Rjected Rjected added C-test A change that impacts how or what we test A-sdk Related to reth's use as a library labels Dec 7, 2024
@mattsse mattsse added this pull request to the merge queue Dec 7, 2024
Merged via the queue into main with commit 42a1ba3 Dec 7, 2024
42 checks passed
@mattsse mattsse deleted the dan/zip-blocks-generic branch December 7, 2024 11:38
lean-apple pushed a commit to lean-apple/reth that referenced this pull request Dec 12, 2024
@Rjected @lean-apple
chore: make zip_blocks generic over header (paradigmxyz#13199)
2f38b5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse