refactor: simplify and relax some RPC bounds #13202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
emhane and
joshieDo
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
DebugApi,TraceApi,EthPubSubandEthFiltersso that they obtain provider and network handle fromEthApiwhich is required to hold both throughRpcNodeCore. This allowed to simplify some of the boundsAdditionally this relaxes bounds for
DebugApito not depend on concrete primitives and forValidationApito not depend on concrete receipt type, further abstraction ofValidationApiis blocked by abstraction ofExecutionPayloadValidatorover block and payload