Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: relax bounds for eth_simulateV1 #13232

Merged
merged 2 commits into from
Dec 9, 2024
Merged

feat: relax bounds for eth_simulateV1 #13232

merged 2 commits into from
Dec 9, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Dec 9, 2024 •
edited
Loading

Relaxes bounds for last eth endpoint, completing the abstraction of eth namespace.

This is done by extending TransactionCompat trait with build_simulate_v1_transaction which is responsible for convering TransactionRequest to a primitive transaction.

For block building, I've reused methods added to LoadPendingBlock in #13170

Last RPC module left is ValidationApi which needs access to EngineValidator.

mattsse
mattsse approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

moving this into compact makes sense, then we can plugin additional logic externally

@klkvr klkvr added this pull request to the merge queue Dec 9, 2024
@klkvr klkvr mentioned this pull request Dec 9, 2024
Merged
Merged via the queue into main with commit c7c84f2 Dec 9, 2024
42 checks passed
@klkvr klkvr deleted the klkvr/relax-simulate-v1 branch December 9, 2024 19:23
@klkvr klkvr added A-rpc Related to the RPC implementation A-sdk Related to reth's use as a library labels Dec 9, 2024
lean-apple pushed a commit to lean-apple/reth that referenced this pull request Dec 12, 2024
@klkvr @lean-apple
feat: relax bounds for eth_simulateV1 (paradigmxyz#13232)
d2487cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation A-sdk Related to reth's use as a library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse