Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: relax bounds for EngineApiTreeHandler #13257

Merged
merged 4 commits into from
Dec 10, 2024
Merged

feat: relax bounds for EngineApiTreeHandler #13257

merged 4 commits into from
Dec 10, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Dec 10, 2024

Based on #13256
Closes #13244

Abstracts EngineApiTreeHandler over node primitives. This required making InsertBlockErrorTwo and FromEngine generic over primitives

@github-actions github-actions bot added A-consensus Related to the consensus engine A-sdk Related to reth's use as a library labels Dec 10, 2024
Base automatically changed from klkvr/engine-generic to main December 10, 2024 02:22
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse enabled auto-merge December 10, 2024 08:53
@mattsse mattsse added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit da99986 Dec 10, 2024
42 checks passed
@mattsse mattsse deleted the klkvr/relax-engine branch December 10, 2024 09:21
lean-apple pushed a commit to lean-apple/reth that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Related to the consensus engine A-sdk Related to reth's use as a library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace hardcoded data primitives in EngineApiTreeHandler impl
2 participants