feat: remove default receipts for network components #13371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
A-networking
Rjected
requested review from
mattsse,
onbjerg,
emhane and
klkvr
as code owners
Rjected
changed the title
mattsse
approved these changes
Dec 12, 2024
Comment on lines
205
to
209
| .map(|receipt| { | ||
| // TODO: use `into_with_bloom` on new alloy release | ||
| let bloom = receipt.bloom(); | ||
| ReceiptWithBloom::new(receipt, bloom) | ||
| }) |
There was a problem hiding this comment.
I believe map(ReceiptWithBloom::from) should work here
Comment on lines
+665
to
+666
| Node::Provider: | ||
| BlockReader<Receipt = N::Receipt, Block = N::Block, Header = N::BlockHeader>, |
There was a problem hiding this comment.
once merged we can add a type alias for this BlockReaderFor<N>
Rjected
force-pushed
the
dan/remove-default-receipts
branch
from
a5cb6b4 to
7687d11
Compare
emhane
pushed a commit
to ethereum-optimism/op-reth
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some default
Receipttypes, replacing with the associated type fromNetworkPrimitives.