Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add roundtrip test for StaticFileSegment filename #13381

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

joshieDo
Copy link
Collaborator

Ensures that any #[strum(serialize = "{SEGMENT}")] can be parsed as a StaticFileSegment

@joshieDo joshieDo added C-test A change that impacts how or what we test A-static-files Related to static files labels Dec 13, 2024
@joshieDo joshieDo requested a review from mattsse December 13, 2024 12:58
@joshieDo joshieDo requested a review from shekhirin as a code owner December 13, 2024 12:58
@joshieDo joshieDo enabled auto-merge December 13, 2024 13:03
@joshieDo joshieDo added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit a69abd4 Dec 13, 2024
42 checks passed
@joshieDo joshieDo deleted the joshie/rtr branch December 13, 2024 13:32
emhane pushed a commit to ethereum-optimism/op-reth that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-static-files Related to static files C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants