New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: expose execution error of debug_cmd/merkle.rs #13515

Merged

mattsse merged 1 commit into paradigmxyz:main from bendanzhentan:chore-expose-execution-error

Dec 23, 2024

Contributor

bendanzhentan commented Dec 23, 2024

The assert! conceals the underlying execution errors, and exposing these errors would help to identify the root cause of the execution.


          chore: expose execution error of debug_cmd/merkle.rs

2a1f493

bendanzhentan requested a review from onbjerg as a code owner

December 23, 2024 09:11

mattsse approved these changes

View reviewed changes

Collaborator

mattsse left a comment

seems reasonable because this fn returns a result.

ty

mattsse added this pull request to the merge queue

Merged via the queue into paradigmxyz:main with commit 0d8efd8

44 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet