Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate OpPrimitives #13556

Merged
merged 30 commits into from
Dec 27, 2024
Merged

feat: integrate OpPrimitives #13556

merged 30 commits into from
Dec 27, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Dec 25, 2024 •
edited
Loading

Based on #13558

Introduces OpPrimitives and integrates them into OpNode

This disables --engine.legacy flag for op-reth and removes maybe_reorg logic from EngineNodeLauncher until #12750 is resolved

@klkvr klkvr force-pushed the klkvr/use-op-primitives branch from e954772 to f3f1506 Compare December 25, 2024 18:04
mattsse
mattsse approved these changes Dec 27, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mattsse mattsse added this pull request to the merge queue Dec 27, 2024
@mattsse mattsse removed this pull request from the merge queue due to a manual request Dec 27, 2024
@klkvr klkvr enabled auto-merge December 27, 2024 15:00
@klkvr klkvr added this pull request to the merge queue Dec 27, 2024
Merged via the queue into main with commit 4994cdf Dec 27, 2024
43 checks passed
@klkvr klkvr deleted the klkvr/use-op-primitives branch December 27, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse