chore: remove optimism feature from execution-types tests #13676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-enhancement
mattsse
approved these changes
Jan 6, 2025
Rjected
force-pushed
the
dan/remove-optimism-execution-types-tests
branch
2 times, most recently
from
79ecccf to
2bff95a
Compare
Rjected
force-pushed
the
dan/remove-optimism-execution-types-tests
branch
from
2bff95a to
3819f40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using
reth_primitives::Receiptfor these tests, and receipt init would require us to feature gate the test. This removes the optimism feature flags on the tests, by usingreth_eth_primitives::Receiptin tests, also creatingTestPrimitivesjust for this crate. We can remove it when we start usingreth_eth_primitives::ReceiptinEthPrimitives