Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added BeaconConsensusEngineHandle to RpcHandle #14348

Merged
merged 1 commit into from
Feb 9, 2025
Merged

added BeaconConsensusEngineHandle to RpcHandle #14348

merged 1 commit into from
Feb 9, 2025

Conversation

PoulavBhowmick03
Copy link
Contributor

@PoulavBhowmick03 PoulavBhowmick03 commented Feb 9, 2025 •
edited by mattsse
Loading

Fixes #14347

closes #14241

@PoulavBhowmick03 PoulavBhowmick03 force-pushed the clone_beacon_enginehandle branch from 2374bc1 to a92c589 Compare February 9, 2025 16:26
mattsse
mattsse approved these changes Feb 9, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @Dinonard

this now gives you the handle to emit engine messages directly

@mattsse mattsse added this pull request to the merge queue Feb 9, 2025
@mattsse mattsse added A-engine Related to the engine implementation A-sdk Related to reth's use as a library labels Feb 9, 2025
Merged via the queue into paradigmxyz:main with commit d57535c Feb 9, 2025
44 checks passed
@PoulavBhowmick03 PoulavBhowmick03 deleted the clone_beacon_enginehandle branch February 10, 2025 04:17
@Dinonard
Copy link

Thank you, that was fast!

18aaddy pushed a commit to 18aaddy/reth that referenced this pull request Feb 12, 2025
@PoulavBhowmick03 @18aaddy
added BeaconConsensusEngineHandle to RpcHandle (paradigmxyz#14348)
41566ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees
No one assigned
Labels
A-engine Related to the engine implementation A-sdk Related to reth's use as a library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add BeaconConsensusEngineHandle to RpcHandle Access to BeaconConsensusEngine API
3 participants
@PoulavBhowmick03 @Dinonard @mattsse