Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grafana): use correct datasource for all metrics #14432

Merged
merged 1 commit into from
Feb 12, 2025
Merged

fix(grafana): use correct datasource for all metrics #14432

merged 1 commit into from
Feb 12, 2025

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Feb 12, 2025

Some metrics were still using DS_PROMETHEUS instead of the new variable that we have

@Rjected Rjected added C-bug An unexpected or incorrect behavior A-observability Related to tracing, metrics, logs and other observability tools labels Feb 12, 2025
@mattsse mattsse merged commit bb67c0e into main Feb 12, 2025
45 checks passed
@mattsse mattsse deleted the dan/fix-datasource-grafana branch February 12, 2025 13:30
frankudoags pushed a commit to frankudoags/reth that referenced this pull request Feb 13, 2025
@Rjected @frankudoags
fix(grafana): use correct datasource for all metrics (paradigmxyz#14432)
8b3a4e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse