feat: add MaybeSerdeBincodeCompat to SignedTx #14433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leruaa
requested review from
Rjected,
joshieDo,
mattsse and
klkvr
as code owners
mattsse
requested changes
Feb 12, 2025
crates/primitives-traits/src/node.rs
Outdated
| @@ -15,7 +15,7 @@ pub trait NodePrimitives: | |||
| /// Block body primitive. | |||
| type BlockBody: FullBlockBody<Transaction = Self::SignedTx, OmmerHeader = Self::BlockHeader>; | |||
| /// Signed version of the transaction type. | |||
| type SignedTx: FullSignedTx; | |||
| type SignedTx: FullSignedTx + MaybeSerdeBincodeCompat; | |||
There was a problem hiding this comment.
can we move this to FullSignedTx instead
like:
reth/crates/primitives-traits/src/block/body.rs
Lines 13 to 15 in 77bd211
mattsse
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to do that:
reth/crates/primitives-traits/src/serde_bincode_compat.rs
Lines 53 to 56 in ea40f78
with
NodePrimitives, I needSignedTxto beMaybeSerdeBincodeCompat.