-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: log indexing #4167
feat: log indexing #4167
Conversation
Should we take a serious crack at getting this over the line? i.e. update description, get ppl to review, make sure CI passes, remove from draft status? As discussed, this should be in alpha.8, so assuming in 2 Mondays, so prob we should start soon? |
cd5bfcc
to
f81ddae
Compare
Codecov Report
Additional details and impacted files
... and 250 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ee765ba
to
3637ab2
Compare
3637ab2
to
4e52ec0
Compare
The primary motivation for this PR was to improve the performance of log-related RPC handlers. Upon taking a closer look at the current implementation, we found and fixed an existing bottleneck which had severely degraded the log filter query performance (#5805). As of now our log query response time is satisfactory, so we are closing this PR to avoid incurring extra storage overhead by maintaining addition log indexes. Even then, such an approach only improves the lookup of rarely occurring logs and would arguably be worse for frequent log filter parameters e.g. Transfer & Deposit topics, common ERC20 or DEX log addresses |
#3082 re-opened.
TBD