feat: use mmap in NippyJar::load and NippyJarCursor
#4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
... and 6 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
onbjerg
approved these changes
Sep 18, 2023
| @@ -36,10 +35,13 @@ impl<'a> NippyJarCursor<'a> { | |||
| config: &'a NippyJar, | |||
| zstd_decompressors: Option<Mutex<Vec<Decompressor<'a>>>>, | |||
| ) -> Result<Self, NippyJarError> { | |||
| let file = File::open(config.data_path())?; | |||
| let mmap = unsafe { Mmap::map(&file)? }; | |||
There was a problem hiding this comment.
should note that this doesn't makes any guarantees about how/when things are flushed - dirty pages can be flushed at will since we do not do any shadow paging or other sync mechanisms. if that's fine then this PR looks good to me
There was a problem hiding this comment.
this only deals with read only files/buffer, so it should be fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR into #4622
Uses mmap to load the configuration and to read data with the cursor.