feat(consensus): support test for check_gas_limit function
#5329
Conversation
| fn create_header(gas_limit: u64) -> SealedHeader { | ||
| SealedHeader { header: Header { gas_limit, ..Default::default() }, ..Default::default() } | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_invalid_gas_limit_increase_exceeding_limit() { | ||
| let parent = create_header(1024 * 10); |
There was a problem hiding this comment.
not sure we need a method just for this, we can probably create the headers directly with the specified gas limits, like with the first few tests
There was a problem hiding this comment.
we're still using create_header here, would recommend removing the method and creating the headers manually in tests
| let mut chain_spec = ChainSpec::default(); | ||
| chain_spec.hardforks.insert(Hardfork::London, ForkCondition::Block(1)); | ||
|
|
||
| assert_eq!(check_gas_limit(&parent, &child, &chain_spec), Ok(())); |
There was a problem hiding this comment.
this probably won't test anything related to london since parent and child both have block number zero in this case, I would set the block number of the parent, and have London fork at block zero when testing block number edge cases
Ty for your help ! Appreciate lot! |
rkrasiuk
changed the title
check_gas_limit function
| fn create_header(gas_limit: u64) -> SealedHeader { | ||
| SealedHeader { header: Header { gas_limit, ..Default::default() }, ..Default::default() } | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_invalid_gas_limit_increase_exceeding_limit() { | ||
| let parent = create_header(1024 * 10); |
There was a problem hiding this comment.
we're still using create_header here, would recommend removing the method and creating the headers manually in tests
| } | ||
|
|
||
| #[test] | ||
| #[ignore] |
There was a problem hiding this comment.
why is this ignored? should probably not be ignored
No description provided.