Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bin) : refactor auth_jwt_secret function #5332

Closed
wants to merge 15 commits into from
Closed

feat(bin) : refactor auth_jwt_secret function #5332

wants to merge 15 commits into from

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

No description provided.

Rjected
Rjected requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to having the get_or_create logic in a separate method to make some things simpler

bin/reth/src/args/rpc_server_args.rs Outdated
Comment on lines 461 to 469
fn get_or_create_jwt_secret_from_path(path: &Path) -> Result<JwtSecret, JwtError> {
if path.exists() {
debug!(target: "reth::cli", ?path, "Reading JWT auth secret file");
JwtSecret::from_file(path)
} else {
info!(target: "reth::cli", ?path, "Creating JWT auth secret file");
JwtSecret::try_create(path)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should just be a separate method, since it doesn't rely on the RpcServerArgs at all

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should just be a separate method, since it doesn't rely on the RpcServerArgs at all

Thank you for this. Can you please suggest me where i can write this function ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can put this in utils

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can put this in utils

Thank you. The function is now in utils !

mattsse
mattsse requested changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function looks good, but needs to be in CLI crate

mattsse
mattsse requested changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this contains a lot of unrelated changes,
perhaps it's easier to reopen this one with only the extracted function

@DoTheBestToGetTheBest
Copy link
Contributor Author

this contains a lot of unrelated changes, perhaps it's easier to reopen this one with only the extracted function

based, ty lot boss!

@DoTheBestToGetTheBest DoTheBestToGetTheBest mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse requested changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@Rjected Rjected Awaiting requested review from Rjected

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DoTheBestToGetTheBest @Rjected @mattsse