Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): add blob support for TransactionRequest #5382

Merged
merged 7 commits into from
Nov 10, 2023

Conversation

itsdevbear
Copy link
Contributor

@itsdevbear itsdevbear commented Nov 10, 2023

Closes: #5118

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I doubt this will be used often but nice to have

@mattsse mattsse enabled auto-merge November 10, 2023 23:40
@mattsse mattsse added the A-rpc Related to the RPC implementation label Nov 10, 2023
@itsdevbear
Copy link
Contributor Author

thanks @mattsse could you explain the changes you made with the matching (I am in the process of learning rust).

if there are any other easy tasks to hit lmk (I know geth in an out) so it's been a lot of pattern matching

@mattsse mattsse added this pull request to the merge queue Nov 10, 2023
@mattsse
Copy link
Collaborator

mattsse commented Nov 10, 2023

sure,

so this one just collapses the two variants:

7e4aa31#diff-d299afe14807edd91a3823e375bf3c57a950e6149370edf075375464b65a6b0aR113-R116

we don't care about fees here in this call because we will set them separately.

and for blob transactions we require all fields because we can't set any of them manually
7e4aa31#diff-d299afe14807edd91a3823e375bf3c57a950e6149370edf075375464b65a6b0aR138-R142

@itsdevbear
Copy link
Contributor Author

makes sense, thanks dude

@mattsse
Copy link
Collaborator

mattsse commented Nov 10, 2023

if there are any other easy tasks to hit lmk (I know geth in an out) so it's been a lot of pattern matching

hehe, yeah it do be like that

I don't have anything specific atm, but adding the eth_blobGasPrice function would be an easy task, even if perhaps premature

https://twitter.com/TimBeiko/status/1722637396792189234

ref:

async fn gas_price(&self) -> RpcResult<U256>;

the implementation should just return "unimplmented" for now

Merged via the queue into paradigmxyz:main with commit 55db2dc Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add blob support in TransactionRequest
2 participants