-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): add blob support for TransactionRequest #5382
Conversation
9b3ff7e
to
a59f9b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, I doubt this will be used often but nice to have
thanks @mattsse could you explain the changes you made with the matching (I am in the process of learning rust). if there are any other easy tasks to hit lmk (I know geth in an out) so it's been a lot of pattern matching |
sure, so this one just collapses the two variants: 7e4aa31#diff-d299afe14807edd91a3823e375bf3c57a950e6149370edf075375464b65a6b0aR113-R116 we don't care about fees here in this call because we will set them separately. and for blob transactions we require all fields because we can't set any of them manually |
makes sense, thanks dude |
hehe, yeah it do be like that I don't have anything specific atm, but adding the eth_blobGasPrice function would be an easy task, even if perhaps premature https://twitter.com/TimBeiko/status/1722637396792189234 ref: reth/crates/rpc/rpc-api/src/eth.rs Line 197 in d108c75
the implementation should just return "unimplmented" for now |
Closes: #5118