feat(rpc-testing-utils) : make replay transactions reponses comparaison in RpcComparer. #5407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoTheBestToGetTheBest
requested review from
mattsse and
Rjected
as code owners
rkrasiuk
added
A-rpc
rkrasiuk
reviewed
Nov 13, 2023
mattsse
requested changes
Nov 13, 2023
| @@ -22,5 +22,8 @@ futures.workspace = true | |||
| jsonrpsee = { workspace = true, features = ["client", "async-client"] } | |||
| serde_json.workspace = true | |||
|
|
|||
|
|
|||
| # Assertions | |||
| pretty_assertions = "1.4.0" | |||
There was a problem hiding this comment.
use similar_asserts
oh really sorry, didn't saw that you said similar_asserts, i don't know how i didn't read this, sorry again
updated
mattsse
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr introduces a new feature to the RpcComparer struct by adding the compare_replay_transaction_responses. This handle comparisons of replay_transactions responses from two different RPC clients example would be reth & geth