chore: put env types into container type #5436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
approved these changes
Nov 15, 2023
joshieDo
approved these changes
Nov 15, 2023
DaniPopes
requested changes
Nov 15, 2023
Co-authored-by: DaniPopes <[email protected]>
|
@mattsse Is the generic even needed? Why can't it be an extra field on the type? Feels excessive for just one flag constant |
|
@DaniPopes yeah this is not really needed because it's just for accessing the flags, can by copied on install. want to change that separately |
DaniPopes
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will allow us to eventually put this in an arc so we no longer need to borrow an Environment