Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make decode_enveloped args consistent with other fns #5456

Merged
merged 1 commit into from
Nov 16, 2023
Merged

chore: make decode_enveloped args consistent with other fns #5456

merged 1 commit into from
Nov 16, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 16, 2023

should not take owned Bytes,

use same args as other decode functions

@mattsse mattsse added the C-debt A clean up/refactor of existing code label Nov 16, 2023
Rjected
Rjected approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@Rjected Rjected added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit 64500e9 Nov 16, 2023
@Rjected Rjected deleted the matt/consistent-decode-arg-types branch November 16, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected