Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipeline: error on missing buffer in online stages #5480

Merged
merged 2 commits into from
Nov 18, 2023
Merged

pipeline: error on missing buffer in online stages #5480

merged 2 commits into from
Nov 18, 2023

Conversation

rkrasiuk
Copy link
Member

Description

Error on missing buffer in online stages. This will ensure that Stage::poll_execute_ready was called before Stage::execute.

@rkrasiuk rkrasiuk added C-enhancement New feature or request A-staged-sync Related to staged sync (pipelines and stages) labels Nov 17, 2023
@rkrasiuk rkrasiuk requested a review from mattsse November 17, 2023 21:39
mattsse
mattsse approved these changes Nov 18, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mattsse
mattsse reviewed Nov 18, 2023
View reviewed changes
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/stage-missing-buffer branch from 01cc0c7 to 6eddcf0 Compare November 18, 2023 08:05
@rkrasiuk rkrasiuk enabled auto-merge November 18, 2023 08:06
@rkrasiuk rkrasiuk added this pull request to the merge queue Nov 18, 2023
Merged via the queue into main with commit 6ded643 Nov 18, 2023
@rkrasiuk rkrasiuk deleted the rkrasiuk/stage-missing-buffer branch November 18, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

Assignees
No one assigned
Labels
A-staged-sync Related to staged sync (pipelines and stages) C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @mattsse