Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: some multiplex followup #5553

Merged
merged 2 commits into from
Nov 24, 2023
Merged

chore: some multiplex followup #5553

merged 2 commits into from
Nov 24, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 23, 2023

more multiplex work

fixes a bug in the find by offset impl and adds better docs

@mattsse mattsse requested a review from Rjected as a code owner November 23, 2023 19:32
@mattsse mattsse requested a review from rkrasiuk November 23, 2023 19:32
@mattsse mattsse added the C-debt A clean up/refactor of existing code label Nov 23, 2023
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, pending @Rjected. still catching up on the original work in #5413

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a doc note

@mattsse mattsse enabled auto-merge November 24, 2023 12:27
@mattsse mattsse added this pull request to the merge queue Nov 24, 2023
Merged via the queue into main with commit 62cebf0 Nov 24, 2023
@mattsse mattsse deleted the matt/multiplex-cleanup branch November 24, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants