perf(trie): use smallvec as the Nibbles representation #5641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
changed the title
DaniPopes
force-pushed
the
dani/smol-nibbles
branch
from
22c38ab to
7abb8c4
Compare
DaniPopes
requested review from
rkrasiuk,
rakita,
joshieDo and
gakonst
as code owners
DaniPopes
changed the title
rkrasiuk
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5631
Use
SmallVec<[u8; 64]>as the Nibbles internal representation to allow storing bytes inline, rather than on the heap.SmallVecfalls back to storing on the heap when the stack capacity would overflow.Also optimize packing to account for this fact.