Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use StageConfig for more reth node methods #5663

Merged
merged 2 commits into from
Dec 2, 2023
Merged

chore: use StageConfig for more reth node methods #5663

merged 2 commits into from
Dec 2, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Dec 2, 2023

Methods like build_pipeline and build_networked_pipeline don't need to take the full Config. This refactors them to take just the StageConfig

@Rjected Rjected added C-enhancement New feature or request A-cli Related to the reth CLI labels Dec 2, 2023
@Rjected Rjected requested a review from onbjerg as a code owner December 2, 2023 02:36
rkrasiuk
rkrasiuk approved these changes Dec 2, 2023
View reviewed changes
@rkrasiuk rkrasiuk enabled auto-merge December 2, 2023 09:01
@rkrasiuk rkrasiuk added this pull request to the merge queue Dec 2, 2023
Merged via the queue into main with commit 7fdd913 Dec 2, 2023
@rkrasiuk rkrasiuk deleted the dan/use-stage-config-in-more-places branch December 2, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @rkrasiuk